player/player.go: fix PickBlock nil pointer #933
Closed
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaPigGuy
requested changes
Nov 15, 2024
| @@ -1888,7 +1888,10 @@ func (p *Player) PickBlock(pos cube.Pos) { | |||
| if pi, ok := b.(block.Pickable); ok { | |||
| pickedItem = pi.Pick() | |||
| } else if i, ok := b.(world.Item); ok { | |||
| it, _ := world.ItemByName(i.EncodeItem()) | |||
| it, ok := world.ItemByName(i.EncodeItem()) | |||
There was a problem hiding this comment.
This is a workaround. EncodeItem should always be returning a valid registered item id & meta.
There was a problem hiding this comment.
I swear to you, it crashed my server. For some reason it doesn't
There was a problem hiding this comment.
That sounds like an issue to debug. Could you find out when that happens?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.