Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double chest #872

Merged
merged 53 commits into from
Aug 15, 2024
Merged

double chest #872

merged 53 commits into from
Aug 15, 2024

Conversation

xNatsuri
Copy link
Contributor

Working Double Chest (built off Raptors PR)

@RestartFU
Copy link
Contributor

double chests do not drop when broken in survival

@RestartFU
Copy link
Contributor

double chests do not drop when broken in survival

fixed

Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, mostly wrt documentation. The actual logic is probably better checked by @T14Raptor given he's looked into this before.

server/block/chest.go Outdated Show resolved Hide resolved
server/item/inventory/inventory.go Outdated Show resolved Hide resolved
server/item/inventory/inventory.go Outdated Show resolved Hide resolved
server/player/player.go Outdated Show resolved Hide resolved
server/block/chest.go Outdated Show resolved Hide resolved
server/block/chest.go Outdated Show resolved Hide resolved
server/block/chest.go Outdated Show resolved Hide resolved
@xNatsuri xNatsuri changed the title Double Chest double chest May 31, 2024
@RestartFU
Copy link
Contributor

RestartFU commented Jul 20, 2024

oh my fucking god
I fucked it up

edit: we good

@TwistedAsylumMC TwistedAsylumMC merged commit ef1263a into df-mc:master Aug 15, 2024
1 check passed
@xNatsuri xNatsuri deleted the double-chest branch August 16, 2024 01:48
@xNatsuri xNatsuri mentioned this pull request Aug 18, 2024
@DaPigGuy DaPigGuy mentioned this pull request Aug 19, 2024
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants