[Azure] Refresh AAD token on retry #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glharper
approved these changes
Aug 15, 2024
| @@ -485,7 +485,7 @@ export class AzureOpenAI extends OpenAI { | |||
| } | |||
|
|
|||
| protected override async prepareOptions(opts: Core.FinalRequestOptions<unknown>): Promise<void> { | |||
| if (opts.headers?.['Authorization'] || opts.headers?.['api-key']) { | |||
There was a problem hiding this comment.
Will this will overwrite an Authorization header passed by the user?
There was a problem hiding this comment.
We don't support the scenario of passing a single AAD token in the authorization header manually. The client constructor requires the user to provide either an API key or an AAD token provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
The AAD token may need to be refreshed between retries so this fix makes sure to always call the token provider irrespective of whether the authorization header is being set.
Additional context & links