Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding scoop chart #229

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding scoop chart #229

wants to merge 3 commits into from

Conversation

YashasviDevtron
Copy link
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 25, 2024
View reviewed changes
charts/scoop/templates/clusterrole.yaml Outdated
- apiGroups:
- '*'
resources:
- '*'

Check warning

Code scanning / SonarCloud

Wildcards should not be used to define RBAC permissions

<!--SONAR_ISSUE_KEY:AZBNv3oer0bfdS6iZmob-->Do not use wildcards when defining RBAC permissions. <p>See more on <a href="https://sonarcloud.io/project/issues?id=devtron-labs_charts&issues=AZBNv3oer0bfdS6iZmob&open=AZBNv3oer0bfdS6iZmob&pullRequest=229">SonarCloud</a></p>
charts/scoop/templates/clusterrole.yaml Outdated
- apiGroups:
- extensions
resources:
- '*'

Check warning

Code scanning / SonarCloud

Wildcards should not be used to define RBAC permissions

<!--SONAR_ISSUE_KEY:AZBNv3oer0bfdS6iZmoc-->Do not use wildcards when defining RBAC permissions. <p>See more on <a href="https://sonarcloud.io/project/issues?id=devtron-labs_charts&issues=AZBNv3oer0bfdS6iZmoc&open=AZBNv3oer0bfdS6iZmoc&pullRequest=229">SonarCloud</a></p>
charts/scoop/templates/clusterrole.yaml Outdated
- apiGroups:
- apps
resources:
- '*'

Check warning

Code scanning / SonarCloud

Wildcards should not be used to define RBAC permissions

<!--SONAR_ISSUE_KEY:AZBNv3oer0bfdS6iZmod-->Do not use wildcards when defining RBAC permissions. <p>See more on <a href="https://sonarcloud.io/project/issues?id=devtron-labs_charts&issues=AZBNv3oer0bfdS6iZmod&open=AZBNv3oer0bfdS6iZmod&pullRequest=229">SonarCloud</a></p>
charts/scoop/templates/deployment.yml Outdated
{{- if $.Values.labels }}
{{ toYaml $.Values.labels | indent 4 }}
{{- end }}
spec:

Check warning

Code scanning / SonarCloud

Service account tokens should not be mounted in pods

<!--SONAR_ISSUE_KEY:AZBNv3oFr0bfdS6iZmoa-->Set automountServiceAccountToken to false for this specification of kind Deployment. <p>See more on <a href="https://sonarcloud.io/project/issues?id=devtron-labs_charts&issues=AZBNv3oFr0bfdS6iZmoa&open=AZBNv3oFr0bfdS6iZmoa&pullRequest=229">SonarCloud</a></p>
ajaydevtron
ajaydevtron requested changes Jun 26, 2024
View reviewed changes
charts/scoop/.helmignore Outdated Show resolved Hide resolved
charts/scoop/Chart.yaml Outdated Show resolved Hide resolved
charts/scoop/templates/deployment.yml Outdated Show resolved Hide resolved
charts/scoop/templates/deployment.yml Outdated Show resolved Hide resolved
charts/scoop/templates/deployment.yml Outdated Show resolved Hide resolved
charts/scoop/templates/deployment.yml Outdated
labels:
app: "deployment-chart-4-18-0"
release: "release-name"
{{- if $.Values.labels }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here rendering we not required for extra levels .

charts/scoop/templates/deployment.yml Outdated Show resolved Hide resolved
charts/scoop/templates/deployment.yml Outdated Show resolved Hide resolved
charts/scoop/templates/deployment.yml Outdated Show resolved Hide resolved
charts/scoop/templates/deployment.yml Outdated Show resolved Hide resolved
@gitguardian GitGuardian
Copy link

gitguardian bot commented Jun 26, 2024 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 26, 2024
View reviewed changes
charts/scoop/templates/deployment.yml Outdated
{{- end }}

containers:
- name: scoop-chart

Check warning

Code scanning / SonarCloud

Memory limits should be enforced

<!--SONAR_ISSUE_KEY:AZBUjEFo3T6AWFMAJtcO-->Specify a memory limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=devtron-labs_charts&issues=AZBUjEFo3T6AWFMAJtcO&open=AZBUjEFo3T6AWFMAJtcO&pullRequest=229">SonarCloud</a></p>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaydevtron ajaydevtron ajaydevtron requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YashasviDevtron @ajaydevtron