Styling Cleanup #10
Closed
Styling Cleanup #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Deven,
Sorry for the confusion. I made my initial PR (#8) thinking I should get a
submission in quickly, and did that one correctly (in terms of git
"correctness"). I later did some additional testing and found some
inconsistencies with the way my assets were loading and wanted to clean
that up. Admittedly, I made a mistake when trying to update my PR (#8) with
new commits, and incorrectly created a new PR (#10) from my new Dev branch.
My correction then was to close the bad PR (#10), and simply do a local PR
again to main in my own repo. So, in the end, PR #8 is my submission. This
maybe explains further why I've got two local PR's, and why there is a
spurious PR to your repo.
On a side note, since this interview process, I've developed a docker rails
image that I hope to use for future development. Lots of other examples
I've seen have one of two problems; requires a local install to get started
with a new project, or caches gems inside the container. The local install
doesn't lend itself well to diagnosing ruby/rails version problems, and
caching inside the container just leads to longer startup times when moving
from one configuration to another (manually launched server vs docker
compose launched).
In any case, thanks for the opportunity. It has been a great learning
process for me and has definitely opened my eyes to Rails again.
Sincerely,
Mike
…On Thu, May 9, 2024 at 5:51 AM devsherm ***@***.***> wrote:
Hi Mike,
I’m not passionate about bootstrap vs tailwind, and could be convinced we
should use Bootstrap.
The only reason we use tailwind is because it was featured in The
Pragmatic Programmer’s Rails 7 book.
Did you close your PR? I’m beginning to review them today.
Thanks!
Deven
From: Mike Tallroth ***@***.***>
Sent: Tuesday, April 30, 2024 5:09 PM
To: devsherm/ShermanEval ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [devsherm/ShermanEval] Styling Cleanup (PR #10)
Learned more about what Tailwind was and how it conflicts w/ Bootstrap.
Cleaned up the styling includes to be Bootstrap only (for better or worse,
at least now it's consistent).
________________________________
You can view, comment on, or merge this pull request online at:
#10
Commit Summary
* 9d13eaf<
9d13eaf>
environment setup, database loaded, app running
* ef029db<
ef029db>
added Survey model
* a258592<
a258592>
add relationship to user
* 3ba7bd5<
3ba7bd5>
bootstrap css and style login view
* f723b4a<
f723b4a>
add sign-up view
* c3ee8e3<
c3ee8e3>
add navbar
* 92c72dc<
92c72dc>
add dropdown, replace authenticated header
* 7c36158<
7c36158>
style fix
* 4296aed<
4296aed>
add surveys controller and new survey view
* a5d349c<
a5d349c>
enhance navbar, add device edit view
* 3e502d2<
3e502d2>
add user name edit view, mod users controller for user self ident
* aa7dd6e<
aa7dd6e>
add survey show view
* 8dd8ef8<
8dd8ef8>
add admin survey controller and views
* d5f2211<
d5f2211>
style fix
* e9e3be2<
e9e3be2>
add survey evaluation actions
* 294e338<
294e338>
update routes.rb
* 05055d4<
05055d4>
prevent users seeing other surveys
* bb82db4<
bb82db4>
link to survey and styling
* d97a0e4<
d97a0e4>
add survey seeds for user ids 1,2,3
* 57c2027<
57c2027>
replace tailwind w/ bootstrap
File Changes
(31 files<https://github.com/devsherm/ShermanEval/pull/10/files>)
* M Gemfile<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-d09ea66f8227784ff4393d88a19836f321c915ae10031d16c93d67e6283ab55f>
(6)
* M Gemfile.lock<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-89cade48462044ee1b672dc5f4c3ec250fbd29effcd8932096a23c1283c6731f>
(22)
* D app/assets/stylesheets/application.tailwind.css<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-ee8509ba5aa9e2a137d0afa09424098c9f2448b66fa955465690c540a47972eb>
(13)
* A app/controllers/admin/admin_controller.rb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-cdcc3b4779b49b8255ea3553e8feb50794f93de5322e9e17c78cca7d82341f0c>
(22)
* A app/controllers/admin/surveys_controller.rb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-2cd6e5ec7743165a009ba8cc2df89beb4cb61c1bb2cb9b0bad29fe877a18fbb6>
(67)
* A app/controllers/surveys_controller.rb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-2c625608ec4c1e6b929bbf1f592ada3d27915aade3be67c98168a964eef0e68c>
(59)
* M app/controllers/users_controller.rb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-cfdccd0a9d5df5a43aaad2a35d36ebbe187c52ad5fdc9846fa189d04537adb6e>
(3)
* A app/helpers/surveys_helper.rb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-d0f7b9e052ea1e59a3ed621f47d6e85f957dda40a1c8f0b6978fb331274aebde>
(2)
* A app/models/survey.rb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-0a836d90715bff613c1484dce2cd38c0c711d180cdeeea9e470368f674c80476>
(4)
* M app/models/user.rb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-9802ca3c9c4cf89904fd44bc114e35ebdf2c5dd3d5b645491e2b253e1afef29b>
(1)
* A app/views/devise/registrations/edit.html.erb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-4d201ae5c67e8b121860359f6c67d044f5bf68c3d7a4687ca64089bfe5677a13>
(59)
* A app/views/devise/registrations/new.html.erb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-744d99555c831425cf5883c199055bc537850fbdd075776c69dbad920497bb1f>
(44)
* A app/views/devise/sessions/new.html.erb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-2bff9166b5e1dfd166a48dd76b315864882b013b55ec69f0aa84db0dda4e1220>
(41)
* M app/views/layouts/application.html.erb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-f43fe075643e681b2c01c2f853bb0c4299d135b47fcbd4da96890d521c49e3eb>
(13)
* A app/views/shared/_navbar.html.erb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-52a7d5013a9b4cec3ba8883dd373ca8752ab378315e8e682c0b80fcb3e5bda4e>
(44)
* A app/views/surveys/_form.html.erb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-421bec91eb33f100649e7979136459f539f5a989725c561a1c2502c5328c5713>
(59)
* A app/views/surveys/_survey.html.erb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-550b3484c46eadbff40b8826e8b9b7d7aa97ae6a7cc372194a3da6b6f90b85f1>
(56)
* A app/views/surveys/index.html.erb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-b753bd58e2f877a60d1ffed78605b5909a5e8fd095f0d2289fd7403c93481807>
(36)
* A app/views/surveys/new.html.erb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-ef55cb36c05748fec4147e91eedfa098f383bfba4600ef5a282b1d0f1b110398>
(6)
* A app/views/surveys/show.html.erb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-4ac761199c64035f14b7a391c967b30658987ed43128b1307df4055cd90f82f8>
(32)
* M app/views/users/_form.html.erb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-8a9c63a61f6015e5c336f715ea8ac568651a1f72548cea06ba302d99ad02e6d4>
(28)
* M app/views/users/edit.html.erb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-7a664d6e0b1d39425223431cffbf717843cbac2e33ac4fe6a58ecb959e38f6ab>
(4)
* M config/database.yml<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-5a674c769541a71f2471a45c0e9dde911b4455344e3131bddc5a363701ba6325>
(2)
* M config/routes.rb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-959bc9abc46a55332bb64d5155a79323afa75a50ec1a2137ddd22d926f62c6c5>
(12)
* D config/tailwind.config.js<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-2de16a68b266f0cafbcddf0a7469415888204e9ca649dbd55b3fbcb5ccb6b229>
(23)
* A db/migrate/20240429014658_create_surveys.rb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-36069a59355e3251a323771422ed067333a242c457656b8df807e76b046dc5b1>
(13)
* M db/schema.rb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-cbf8b25d6d853acf58fa9057841f407d29ffe90649c75cf9e3f51b2d6e3aa1d3>
(14)
* M db/seeds.rb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-c61a903a1201b0c7f076b0270377c20390c26f655ce63689d7d843296fcf63f3>
(6)
* A test/controllers/surveys_controller_test.rb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-f917477be8c841f87b2159ba4c4078fd734caa9b932f5d1ec0dac74fc9095fa4>
(28)
* A test/fixtures/surveys.yml<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-231e0b0332d0b7a7ffe64be5fa2658485c9edb2d66c1ecea1aeaec98c802e6f1>
(13)
* A test/models/survey_test.rb<
https://github.com/devsherm/ShermanEval/pull/10/files#diff-68c8651bdfc6defcad9dee959eea8987e994b3b947d9db47a52cf7766876102f>
(7)
Patch Links:
* https://github.com/devsherm/ShermanEval/pull/10.patch
* https://github.com/devsherm/ShermanEval/pull/10.diff
—
Reply to this email directly, view it on GitHub<
#10>, or unsubscribe<
https://github.com/notifications/unsubscribe-auth/BARJSR4ASKDJ36FNUMKU5JLZAAI7JAVCNFSM6AAAAABHBCBIT2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3TENJVG43DONY>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.******@***.***>>
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEDTHS4ZACPB2HOO2FVCLLZBNIJPAVCNFSM6AAAAABHBCBIT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBSGQZDSNZRHA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learned more about what Tailwind was and how it conflicts w/ Bootstrap. Cleaned up the styling includes to be Bootstrap only (for better or worse, at least now it's consistent).