Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to work with Emscripten 3 #465

Closed
wants to merge 7 commits into from
Closed

Updates to work with Emscripten 3 #465

wants to merge 7 commits into from

Conversation

emilydolson
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #465 (23f6cec) into master (1fe7f90) will increase coverage by 0.64%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   82.96%   83.61%   +0.64%     
==========================================
  Files         306      357      +51     
  Lines       37356    44201    +6845     
==========================================
+ Hits        30994    36958    +5964     
- Misses       6362     7243     +881     
Impacted Files Coverage Δ
include/emp/web/JSWrap.hpp 23.30% <0.00%> (+1.51%) ⬆️
include/emp/web/init.hpp 33.33% <0.00%> (+1.51%) ⬆️
include/emp/tools/timing.hpp 25.00% <0.00%> (-46.43%) ⬇️
include/emp/base/always_assert.hpp 37.03% <0.00%> (-34.40%) ⬇️
include/emp/meta/reflection.hpp 4.76% <0.00%> (-18.77%) ⬇️
include/emp/base/always_assert_warning.hpp 50.00% <0.00%> (-14.29%) ⬇️
tests/math/Distribution.cpp 90.47% <0.00%> (-6.20%) ⬇️
include/emp/web/Document.hpp 16.66% <0.00%> (-4.77%) ⬇️
include/emp/testing/unit_tests.hpp 3.33% <0.00%> (-2.13%) ⬇️
include/emp/datastructs/map_utils.hpp 85.71% <0.00%> (-1.25%) ⬇️
... and 278 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fe7f90...23f6cec. Read the comment docs.

@emilydolson
Copy link
Collaborator Author

Okay, so this is all working fine for non-threaded code, but still breaks if you compile with -pthread, do to #411. I tried pulling in the quickfixes from the native-canvas branch that @mmore500 suggested, but it's still broken.

@emilydolson
Copy link
Collaborator Author

This now also fixes #454

@emilydolson
Copy link
Collaborator Author

Master now works with Emscripten 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant