Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite d3 wrapper to work with current version of d3.js and be better in general #295

Open
wants to merge 145 commits into
base: master
Choose a base branch
from

Conversation

emilydolson
Copy link
Collaborator

This is the pull request for Elizabeth and Oliver's WAVES project, in which they are re-writing the d3 wrapper from the ground up to make it work with the new version of d3 while also making a variety of other improvements along the way.

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #295 (f13b4b8) into master (223f54c) will decrease coverage by 0.32%.
The diff coverage is 78.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   82.96%   82.64%   -0.33%     
==========================================
  Files         306      319      +13     
  Lines       37356    40565    +3209     
==========================================
+ Hits        30994    33526    +2532     
- Misses       6362     7039     +677     
Impacted Files Coverage Δ
include/emp/web/CanvasShape.hpp 0.00% <0.00%> (ø)
include/emp/web/d3/transition.hpp 0.00% <0.00%> (ø)
include/emp/web/init.hpp 39.13% <0.00%> (+7.31%) ⬆️
include/emp/web/d3/svg_shapes.hpp 10.64% <6.85%> (ø)
include/emp/web/d3/selection.hpp 29.65% <30.29%> (ø)
include/emp/web/js_utils.hpp 43.91% <50.00%> (+40.27%) ⬆️
include/emp/web/d3/scales.hpp 67.64% <66.81%> (ø)
include/emp/web/d3/d3_init.hpp 71.15% <69.76%> (ø)
tests/web/d3/transition.cpp 93.33% <93.33%> (ø)
tests/web/d3/shapes.cpp 95.45% <95.45%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 223f54c...f13b4b8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants