-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite d3 wrapper to work with current version of d3.js and be better in general #295
Open
emilydolson
wants to merge
145
commits into
master
Choose a base branch
from
d3-wrapper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-implement D3_Base
…Transition wrapper
add find_function to d3_library, begin SelectionOrTransition re-impl
Merge changes from 2020-06-12 meeting
Progress from d3-wrapper meeting 2020-06-15
Merge commits from 2020-06-16 dev meeting
Fixing dumb mistakes in scales.h
Updates to Axis
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
- Coverage 82.96% 82.64% -0.33%
==========================================
Files 306 319 +13
Lines 37356 40565 +3209
==========================================
+ Hits 30994 33526 +2532
- Misses 6362 7039 +677
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the pull request for Elizabeth and Oliver's WAVES project, in which they are re-writing the d3 wrapper from the ground up to make it work with the new version of d3 while also making a variety of other improvements along the way.