feat: remove eslint issues

devlille · Dec 14, 2024 · ab19d2a · ab19d2a
1 parent c846b35
commit ab19d2a
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/functions/src/cms4devfest.ts b/functions/src/cms4devfest.ts
@@ -5,7 +5,7 @@ import * as functions from 'firebase-functions';
 import relanceConventionSignee from './emails/template/relanceConventionSignee';
 import relanceInformationsComplementaires from './emails/template/relanceInformationsComplementaires';
 import relancePaiement from './emails/template/relancePaiement';
-import { Company, Configuration } from './model';
+import type { Company, Configuration, EmailContent, WorkflowStatus } from './model';
 import { StatusEnum, onDocumentChange } from './utils/document-change';
 import { sendEmail, sendEmailToAllContacts } from './utils/mail';
 import { sendNewPartnerToOrganizationTeam, sendWelcomeEmail } from './v3/domain/email';
@@ -23,7 +23,7 @@ function addCreationDate(id: string) {
     .catch((err) => console.log(err));
 }
 
-function updatesStatus(id: string, company: any, status: any) {
+function updatesStatus(id: string, company: Company, status: WorkflowStatus) {
   return firestore
     .doc('companies-2025/' + id)
     .update({
@@ -51,7 +51,7 @@ export const testEmail = functions.https.onRequest(async (req, resp) => {
   resp.send(1);
 });
 
-const relance = (emailFactory: (partner: Company, configuration: Configuration) => any, partners: Company[], configuration: Configuration) => {
+const relance = (emailFactory: (partner: Company, configuration: Configuration) => EmailContent, partners: Company[], configuration: Configuration) => {
   partners.forEach((c: Company) => {
     const emailTemplate = emailFactory(c, configuration);
     sendEmailToAllContacts(c, emailTemplate, configuration);

diff --git a/functions/src/emails/template/relanceInformationsComplementaires.ts b/functions/src/emails/template/relanceInformationsComplementaires.ts
@@ -1,6 +1,6 @@
-import { Configuration } from '../../model';
+import { Company, Configuration } from '../../model';
 
-export default (partner: Record<string, any>, configuration: Configuration) => {
+export default (partner: Company, configuration: Configuration) => {
   return {
     subject: `Partenariat ${configuration.gdg.event} ${configuration.convention.edition}: Relance Informations Complémentaires`,
     body: `

diff --git a/functions/src/model.ts b/functions/src/model.ts
@@ -1,5 +1,7 @@
 import { Timestamp } from 'firebase-admin/firestore';
 
+export type EmailContent = { subject: string; body: string };
+
 export type Convention = {
   edition: string;
   startdate: string;

diff --git a/functions/src/utils/mail.ts b/functions/src/utils/mail.ts
@@ -1,6 +1,6 @@
 import axios from 'axios';
 
-import { Company, Configuration, Email } from '../model';
+import type { Company, Configuration, Email, EmailContent } from '../model';
 
 export function getFrom(mail: Email): {
   From: { Email: string; Name: string };
@@ -13,7 +13,7 @@ export function getFrom(mail: Email): {
   };
 }
 
-export function sendEmailToAllContacts(company: Company, emailFactory: { subject: string; body: string }, configuration: Configuration) {
+export function sendEmailToAllContacts(company: Company, emailFactory: EmailContent, configuration: Configuration) {
   if (!configuration.mail.enabled) {
     return;
   }