Merge pull request #30 from devinit/feature/charts-feedback

Make more edits for column and map charts
devinit · Mar 24, 2023 · 56f6888 · 56f6888
2 parents a6058ca + 96b54fd
commit 56f6888
Show file tree

Hide file tree

Showing 5 changed files with 453 additions and 449 deletions.
diff --git a/assets/core.js b/assets/core.js
diff --git a/src/.DS_Store b/src/.DS_Store
diff --git a/src/core/EconomicPovertyBarChart.js b/src/core/EconomicPovertyBarChart.js
@@ -17,7 +17,7 @@ const getSeriesNames = (data) => Array.from(new Set(data.map((item) => item['Reg
 const getSeries = (dataArray, years, filterValue) => {
   const seriesNames = getSeriesNames(dataArray);
   const series = seriesNames.map((seriesName) => ({
-    name: seriesName === 'Other High Income Countries' ? 'Other High-Income Countries' : seriesName,
+    name: seriesName === 'Other High Income Countries' ? 'Other high-income countries*' : seriesName,
     type: 'bar',
     stack: 'Region',
     tooltip: {
@@ -30,14 +30,14 @@ const getSeries = (dataArray, years, filterValue) => {
         .filter((item) => item['poverty line (2017 PPP)'] === filterValue)
         .forEach((item) => {
           if (item['Region name'] === seriesName && item.year === year) {
-            yearList.push(Number(Number(item['Population in poverty (billions)']).toFixed(2)));
+            yearList.push(Number(Number(item['Population in poverty (billions)'])));
           }
         });
 
       const accumulatedYearValue = yearList.reduce((accumulator, currentValue) => accumulator + currentValue, 0);
 
       return {
-        value: accumulatedYearValue.toFixed(2),
+        value: accumulatedYearValue.toFixed(3),
         emphasis: {
           focus: 'self',
         },