Add ScanFilter to Central::start_scan() #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwandor
reviewed
Sep 3, 2021
qwandor
reviewed
Sep 3, 2021
qwandor
approved these changes
Sep 4, 2021
|
Are you able to implement this on MacOS and Windows too? |
|
Most of the work for the macOS port is already done and there are only a few lines of code missing. Only a |
|
If you can send another PR for the MacOS implementation that at least compiles and looks correct, I can test it on my machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
requestDevicemethod from WebBluetooth requires a list of service uuids to allow access to characteristics. See the code of #204 for more details.