Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iPad Mini (A17 Pro) #429

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Zandor300
Copy link
Member

Fixes #426

@@ -562,7 +564,7 @@ class DeviceKitTests: XCTestCase {
.iPadPro13M4,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Collection literals should not have trailing commas.
trailing_comma Tests.swift:564

Copy link

13 Warnings
⚠️ Plist changed, don't forget to localize your plist values
⚠️ Source/Device.generated.swift#L687 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:687
⚠️ Source/Device.generated.swift#L1242 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1242
⚠️ Source/Device.generated.swift#L1495 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1495
⚠️ Source/Device.generated.swift#L1662 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1662
⚠️ Source/Device.generated.swift#L1809 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1809
⚠️ Source/Device.generated.swift#L2489 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:2489
⚠️ Source/Device.generated.swift#L2548 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:2548
⚠️ Tests/Tests.swift#L461 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:461
⚠️ Tests/Tests.swift#L492 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:492
⚠️ Tests/Tests.swift#L523 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:523
⚠️ Tests/Tests.swift#L650 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:650
⚠️ Tests/Tests.swift#L683 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:683

SwiftLint found issues

Warnings

File Line Reason
Tests.swift 461 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 492 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 523 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 564 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 650 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 683 Collection literals should not have trailing commas. (trailing_comma)
Device.generated.swift 687 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1242 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1495 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1662 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1809 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 2489 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 2548 TODOs should be resolved (Replace with proper implementa...). (todo)

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iPad mini (A17 Pro) missing
1 participant