Skip to content

refactor: since inputs are signals, removes EventEmitter #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rsdmike
Copy link
Member

@rsdmike rsdmike commented Jun 4, 2025

from selectedEncoding and deviceConnection for KVM,SOL, and IDER components. This
PR also updates Angular to v20.

BREAKING CHANGE: KVM/SOL/IDER inputs are no longer EventEmitters.

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )

rsdmike added 2 commits June 4, 2025 16:02
from selectedEncoding and deviceConnection for KVM,SOL, and IDER components

BREAKING CHANGE: KVM/SOL/IDER inputs are no longer EventEmitters
@rsdmike rsdmike force-pushed the refactor branch 2 times, most recently from 35f2c6e to 22029cc Compare June 5, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant