Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMS-1047: Add image-links sr-text to exhibition archive #32

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

eebbi
Copy link
Contributor

@eebbi eebbi commented Jun 3, 2024

Severa-ID: 2247
Severa-kuvaus: TMS-1047 Vapriikin näyttelylistausvälilehtien kuvalinkit - saavutettavuus
Task: https://hiondigital.atlassian.net/browse/TMS-1047

Description

Add image-links sr-text to exhibition archive

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@eebbi eebbi requested a review from a team June 3, 2024 08:04
@vloy vloy self-assigned this Jun 3, 2024
$item->permalink = \get_the_permalink( $item->ID );
$additional_fields = \get_fields( $item->ID );
$item->post_title = $additional_fields['title'] ?: $item->post_title;
$item->link_sr_text = __( 'Go to exhibition', 'tms-theme-vapriikki' ) . ' ' . $item->post_title;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$item->link_sr_text = __( 'Go to exhibition', 'tms-theme-vapriikki' ) . ' ' . $item->post_title;
$item->link_sr_text = \__( 'Go to exhibition', 'tms-theme-vapriikki' ) . ' ' . $item->post_title;

Copy link

@vloy vloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eebbi eebbi merged commit 90179ab into master Jun 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants