Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMS-1059: Eventz link changes #522

Merged
merged 5 commits into from
Nov 24, 2024
Merged

TMS-1059: Eventz link changes #522

merged 5 commits into from
Nov 24, 2024

Conversation

eebbi
Copy link
Contributor

@eebbi eebbi commented Nov 16, 2024

Severa-ID: 2108
Severa-kuvaus: TMS-1059 Tapahtumasivupohjaan muutos
Task: https://hiondigital.atlassian.net/browse/TMS-1059

Description

  • Add new link-fields to events from Eventz-API
  • Add translations to links that have a default name
  • Fix event short description to include ending html-tags and non-breaking spaces

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@eebbi eebbi requested a review from a team November 16, 2024 12:27
@vloy vloy self-assigned this Nov 18, 2024
lib/Eventz.php Outdated
Comment on lines 118 to 119
$event_link->name = \__( 'Purchase tickets', 'tms-theme-base' );
$event_link_purchase_ticket = $event_link;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$event_link->name = \__( 'Purchase tickets', 'tms-theme-base' );
$event_link_purchase_ticket = $event_link;
$event_link->name = \__( 'Purchase tickets', 'tms-theme-base' );
$event_link_purchase_ticket = $event_link;

lib/Eventz.php Outdated
Comment on lines 122 to 123
$event_link->name = \__( 'Sign up', 'tms-theme-base' );
$event_link_sign_up = $event_link;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$event_link->name = \__( 'Sign up', 'tms-theme-base' );
$event_link_sign_up = $event_link;
$event_link->name = \__( 'Sign up', 'tms-theme-base' );
$event_link_sign_up = $event_link;

Copy link

@vloy vloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eebbi eebbi merged commit 1f25f83 into master Nov 24, 2024
3 of 4 checks passed
@eebbi eebbi deleted the TMS-1059 branch November 24, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants