Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMS-968: Add recurring event fields to manual events #20

Merged
merged 9 commits into from
Mar 26, 2024
Merged

Conversation

eebbi
Copy link
Contributor

@eebbi eebbi commented Mar 18, 2024

Severa-ID: 2147
Severa-kuvaus: TMS-968 Manuaaliset tapahtumat: tapahtuman toistuvuus
Task: https://hiondigital.atlassian.net/browse/TMS-968

Description

  • Add recurring event fields to manual events
  • Add recurring event logic to events component, combined event search & combined event listing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@eebbi eebbi requested a review from a team March 18, 2024 12:43
@vloy vloy self-assigned this Mar 19, 2024
$args = [
'post_type' => PostType\ManualEvent::SLUG,
'posts_per_page' => 200, // phpcs:ignore
's' => $params['q'] ?? '',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
's' => $params['q'] ?? '',
's' => ! empty( $params['q'] ) ? $params['q'] : '',

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'??' operaattori tekee saman, eli käyttää ensimmäistä parametriä jos se on olemassa & ei ole null

Copy link

@vloy vloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@eebbi eebbi merged commit 9888f3a into master Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants