Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lifecycle doc #208

Merged
merged 19 commits into from
Feb 20, 2024
Merged

add lifecycle doc #208

merged 19 commits into from
Feb 20, 2024

Conversation

kim-tsao
Copy link
Collaborator

@kim-tsao kim-tsao commented Sep 29, 2023

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?

Documents a proposed devfile lifecycle management process

Which issue(s) this PR fixes:

Link to github issue(s)

devfile/api#1066

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

LIFECYCLE.md Outdated Show resolved Hide resolved
LIFECYCLE.md Outdated Show resolved Hide resolved
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kim-tsao I've added some minor suggestions. Feel free to reject them if you think they are not correct :)

A qq I have is about versioning. Should we include a section in the lifecycle doc about versioning or you think is un related (e.g how a stack provider should be versioning their stack's versions etc)

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments.

CONTRIBUTING.md Outdated Show resolved Hide resolved
LIFECYCLE.md Outdated Show resolved Hide resolved
LIFECYCLE.md Outdated Show resolved Hide resolved
LIFECYCLE.md Outdated Show resolved Hide resolved
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Looks good to me approved labels Feb 12, 2024
@openshift-ci openshift-ci bot removed the lgtm Looks good to me label Feb 12, 2024
@thepetk thepetk added the lgtm Looks good to me label Feb 12, 2024
@thepetk
Copy link
Contributor

thepetk commented Feb 12, 2024

/retest

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to what I said in one of my review comment, I think we should include a section for ownership transfers in the event a current stack/sample owner can no longer take on this role.

LIFECYCLE.md Outdated Show resolved Hide resolved
LIFECYCLE.md Outdated Show resolved Hide resolved
LIFECYCLE.md Outdated Show resolved Hide resolved
LIFECYCLE.md Outdated Show resolved Hide resolved
LIFECYCLE.md Outdated Show resolved Hide resolved
LIFECYCLE.md Outdated Show resolved Hide resolved
LIFECYCLE.md Outdated Show resolved Hide resolved
LIFECYCLE.md Outdated Show resolved Hide resolved
LIFECYCLE.md Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Looks good to me label Feb 14, 2024
@thepetk
Copy link
Contributor

thepetk commented Feb 16, 2024

In order to spread the word for the stack's lifecycle PR and get as many reviews as possible for the document, I'm listing here all stack providers. Feel free to review the PR so we can optimize our lifecycle processes:

LIFECYCLE.md Outdated Show resolved Hide resolved
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Looks good from my side.

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Feb 16, 2024
Copy link

openshift-ci bot commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LIFECYCLE.md Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Looks good to me label Feb 19, 2024
Copy link

openshift-ci bot commented Feb 19, 2024

New changes are detected. LGTM label has been removed.

@thepetk thepetk requested a review from l0rd February 19, 2024 10:58
kim-tsao and others added 2 commits February 19, 2024 10:58
Signed-off-by: Kim Tsao <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>

Co-authored-by: Armel Soro <[email protected]>
Signed-off-by: thepetk <[email protected]>
thepetk and others added 17 commits February 19, 2024 10:58
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>

Co-authored-by: Armel Soro <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>

Co-authored-by: Armel Soro <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>

Co-authored-by: Armel Soro <[email protected]>
Signed-off-by: thepetk <[email protected]>
Co-authored-by: Michael Valdron <[email protected]>
Signed-off-by: thepetk <[email protected]>
Co-authored-by: Michael Valdron <[email protected]>
Signed-off-by: thepetk <[email protected]>
Co-authored-by: Michael Valdron <[email protected]>
Signed-off-by: thepetk <[email protected]>
Co-authored-by: Michael Valdron <[email protected]>
Signed-off-by: thepetk <[email protected]>
Co-authored-by: Michael Valdron <[email protected]>
Signed-off-by: thepetk <[email protected]>
Co-authored-by: Michael Valdron <[email protected]>
Signed-off-by: thepetk <[email protected]>
Co-authored-by: Michael Valdron <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>

Co-authored-by: Mario Loriedo <[email protected]>
Signed-off-by: thepetk <[email protected]>
@thepetk thepetk merged commit deaa0e6 into devfile:main Feb 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants