Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meetings information under GOVERNANCE #1596

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Jun 11, 2024

What does this PR do?

Updates the out of date information about meetings under GOVERNANCE.md to point to the Meetings section of our community page. Meetings are now ad-hoc instead of every Monday at 9AM EST on a regular schedule.

Which issue(s) does this PR fix

#1515

PR acceptance criteria

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer

GOVERNANCE.md Outdated Show resolved Hide resolved
Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
Copy link
Member Author

Client Impact

N/A

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 11, 2024
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@michael-valdron
Copy link
Member Author

@johnmcollier @yangcao77 Could one of you sign off as well if everything looks good.

Copy link

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jdubrick, johnmcollier, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit cfbdc2b into devfile:main Jun 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants