Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create version 2.0.0 for go-basic sample #29

Merged
merged 13 commits into from
Nov 28, 2023

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Sep 28, 2023

What does this PR do?:

This PR creates a new version of go-basic sample. The new version uses the 2.1.0 version of go stack instead of the default one 1.0.2.

Which issue(s) this PR fixes:

fixes devfile/api#1360

@thepetk thepetk self-assigned this Sep 28, 2023
devfile.yaml Outdated Show resolved Hide resolved
@feloy
Copy link

feloy commented Oct 4, 2023

As discussed during standup, you could move the commands into the parent declaration, so they will override the parent's ones

@maysunfaisal
Copy link
Contributor

maysunfaisal commented Oct 6, 2023

@thepetk I think we discussed this a bit on the call, but do we want to also merge the port update changes with your branch? #26 will help with https://issues.redhat.com/browse/DEVHAS-423

@thepetk
Copy link
Contributor Author

thepetk commented Oct 9, 2023

@thepetk I think we discussed this a bit on the call, but do we want to also merge the port update changes with your branch? #26 will help with https://issues.redhat.com/browse/DEVHAS-423

@maysunfaisal I've added the update of the port from 8081 to 8080

@yangcao77
Copy link
Collaborator

Has this change be tested on ODC, odo and HAS to ensure the port update won't cause any regression?

@thepetk
Copy link
Contributor Author

thepetk commented Oct 16, 2023

Has this change be tested on ODC, odo and HAS to ensure the port update won't cause any regression?

@yangcao77 I think is a good idea to test all new versions on those consumers :)

@yangcao77
Copy link
Collaborator

@thepetk Since we only have one version for all samples currently, any change to samples will directly affect all consumers. plus no ci tests running for samples neither. so it's a requirement to test out before any sample update.

@thepetk
Copy link
Contributor Author

thepetk commented Oct 16, 2023

@thepetk Since we only have one version for all samples currently, any change to samples will directly affect all consumers. plus no ci tests running for samples neither. so it's a requirement to test out before any sample update.

@yangcao77 yup totally agree. One question I have is if we need to update the contributing here https://github.com/devfile/registry/blob/main/CONTRIBUTING.md#samples to include those checks too?

Finally just to clarify, atm all the new version PRs will be merged on different branches than main not known to our consumers. This ofc will change once we update registry's extraDevfileEntries.yaml to support multiple sample versions.

@thepetk thepetk changed the base branch from v1.1.1 to v2.0.0 October 18, 2023 13:53
@thepetk thepetk changed the title Create version 1.1.1 for go-basic sample Create version 2.0.0 for go-basic sample Oct 18, 2023
@thepetk thepetk changed the base branch from v2.0.0 to main October 23, 2023 12:29
@thepetk thepetk changed the title Create version 2.0.0 for go-basic sample [DO NOT MERGE] Create version 2.0.0 for go-basic sample Oct 23, 2023
signed-off-by: thepetk <[email protected]>
@thepetk thepetk changed the base branch from main to v1.1.0 October 23, 2023 15:45
@thepetk thepetk changed the base branch from v1.1.0 to main October 23, 2023 15:46
@thepetk thepetk changed the base branch from main to v2.0.0 November 7, 2023 12:57
@thepetk thepetk changed the title [DO NOT MERGE] Create version 2.0.0 for go-basic sample Create version 2.0.0 for go-basic sample Nov 7, 2023
Signed-off-by: thepetk <[email protected]>
@thepetk
Copy link
Contributor Author

thepetk commented Nov 21, 2023

@maysunfaisal port is now 8080 for the new sample version. Feel free to review!

@thepetk thepetk merged commit f3929fa into devfile-samples:v2.0.0 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Devfile Samples to reference v2.2.0 Parent stacks
4 participants