Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Update port from 8081 to 8080 #23

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[DO NOT MERGE] Update port from 8081 to 8080 #23

wants to merge 4 commits into from

Conversation

maysunfaisal
Copy link
Contributor

  • Updates the devfile sample port from 8081 to 8080
  • Doesnt update the attribute alpha.dockerimage-port: 8081 because of backward compatibility in ODC earlier versions. We dont want to backport devfile/library update that far back.

@maysunfaisal
Update port from 8081 to 8080
20e24db 
Signed-off-by: Maysun J Faisal <[email protected]>
@maysunfaisal maysunfaisal mentioned this pull request Jul 24, 2023
Merged
@thepetk thepetk changed the base branch from main to v1.2.2 October 9, 2023 15:35
@thepetk thepetk marked this pull request as ready for review October 9, 2023 15:38
@thepetk
Copy link
Contributor

thepetk commented Oct 9, 2023 •
edited
Loading

@maysunfaisal I've created a branch in the devfile-sample-code-with-quarkus repo (v2.0.0). We can merge this update to another branch so we can have two versions, one supporting port 8080 and one supporting 8081.

thepetk
thepetk approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@thepetk
Copy link
Contributor

thepetk commented Oct 16, 2023

fixes devfile/api#1112

@thepetk thepetk mentioned this pull request Oct 16, 2023
Closed
@thepetk thepetk changed the base branch from v1.2.2 to v2.0.0 October 18, 2023 14:07
@thepetk thepetk changed the base branch from v2.0.0 to main October 23, 2023 12:25
@thepetk thepetk changed the title Update port from 8081 to 8080 [DO NOT MERGE] Update port from 8081 to 8080 Oct 23, 2023
@thepetk
Update README.md
f7bd5c7 
Signed-off-by: thepetk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thepetk thepetk thepetk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maysunfaisal @thepetk