-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flutter 3.14.4, AGP 8, Dart 3, sensors_plus: ^3.0.3
#29
base: master
Are you sure you want to change the base?
Conversation
Hi Philipp, Thanks so much for the PR. My apologies for this repository being unmaintained for a bit, I was dealing with a few personal issues. I will have this PR reviewed and the new version launched by tomorrow. Thanks so much for the contribution and I'll do more to support the repo going ahead. |
Np. When reviewing, checking the lowest flutter version you want to support makes the most sense (if u had to pick one), but take your time (esp with personal issues!) |
Hi @deven98, if you need any help maintaining the repo you can add me as a contributor. |
@deven98 can you perhaps bump to sensors_plus to 4? So we can use flutter 3.16 |
@deven98 I've submitted a PR for you, that enables support for 3.16 flutter version by supporting sensors_plus v4: |
@simplenotezy I just built our project with Flutter 3.16.2 & the current state of the PR (ie sensors_plus v3.0.3) and everything seems to build & run just fine. In what way was v3 incompatible with Flutter 3.16? Which 3.16.x did you use? |
Hello, @deven98! Any news with reviewing this one? Or maybe you need help with reviewing it? |
Hi @deven98. Kindly pinging to remind that the users of this package still wait for a new version to come in. Do you need any help with updating the package? |
Hi @deven98, are there any plans on merging this at some point? Is there some way to assist you? |
Due to the old version of The solution is to upgrade the |
You can just add ShakeDetector class in your app codebase. This package is just a single class. |
@FeodorFitsner I saw that too, but with |
Will take a look at |
Scratch that - it's for haptic feedback 🫣 |
Essentially this PR combines the open version-update PRs into one and adds some general maintenance on top.
android
folder to shut up the linter about deprecated embeddingflutter_lints
sensors_plus: ^3.0.3
feat(2.3.0): updatesensors_plus
version #27sensors_plus
version #27 doesn't have that because upper limit too low)@ziqq I know it's a waste to essentially recreate your PR, but we need a stable fork that we can rely on anyway, so here it is.
@deven98 Do you plan on reviewing the open PRs anytime soon?