Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-library): does not show icons when undefined #649

Closed
wants to merge 2 commits into from

Conversation

DenizSaganak
Copy link
Contributor

Copy link
Collaborator

@davidken91 davidken91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the compile step is failing. I think you just need to add icons as a property to contentIconButtons index.stories.ts (button group). Something like this:
const contentIconButtons = html
${BlrIconButtonRenderFunction({
size: 'md',
theme: 'Light',
loading: false,
variant: 'primary',
loadingStatus: 'Loading',
disabled: false,
arialabel: 'button_1',
icon: 'blr360'
})}
${BlrIconButtonRenderFunction({
size: 'md',
theme: 'Light',
loading: false,
variant: 'secondary',
loadingStatus: 'Loading',
disabled: false,
arialabel: 'button_2',
icon: 'blrInfo'
})}
;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📋 task::inProgress Task someone is working on already
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants