Get build working and run compile in the pipeline #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikdi
reviewed
Nov 17, 2023
ChristianHoffmannS2
force-pushed
the
get-build-working
branch
from
c05361f
to
98eedd5
Compare
ChristianHoffmannS2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it possible to import our components in svelte/react using the path "@boiler/ui-library" inside of tsx/ts/svelte files
The compile step is also needed here to get a main.d.ts file so that svelte/react can use this in a typesafe way.
The compile will also be running in pipelines to give us ts errors for ALL ts files and not just the ones included by the build it self
(namely: tests & stories)
Note: the build only includes whats exported in the ui-library/index.ts file.
We should get that file generated instead of handwritten at some point