Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added two tests for mars crs's #159

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

AndrewAnnex
Copy link
Contributor

Adds two tests that are currently failing to correctly return the expected xy_bbox or bbox for the two CRSs considered.
not sure why but somehow using IAU CRSs that are inverted (latitude longitude order) doesn't seem to work with the latest #158. Maybe this _pyproj_crs.geodetic_crs switching around the axes?

@AndrewAnnex AndrewAnnex changed the title added two failing tests for mars crss added two failing tests for mars crs's Oct 15, 2024
tests/test_models.py Outdated Show resolved Hide resolved
Co-authored-by: Vincent Sarago <[email protected]>
tests/test_models.py Outdated Show resolved Hide resolved
@AndrewAnnex AndrewAnnex changed the title added two failing tests for mars crs's added two tests for mars crs's Oct 15, 2024
@AndrewAnnex
Copy link
Contributor Author

AndrewAnnex commented Oct 15, 2024

@vincentsarago thanks and sorry for all the typo's, think this is now all fine and good and may help catch any possible future regressions

@vincentsarago vincentsarago merged commit da1b237 into developmentseed:main Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants