WASM Build #59
Open
WASM Build #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bitner
commented
Feb 12, 2025
bitner
commented
- Swap out from Boon to JsonSchema (Boon did not work with wasm) Fixes Switch to jsonschema #46
- Add Wasm package Fixes Expose to WASM #11
- Add Wasm Playground to Docs
gadomski
approved these changes
Feb 13, 2025
Comment on lines
+23
to
+24
| - name: Install Rust | ||
| uses: dtolnay/rust-toolchain@stable |
There was a problem hiding this comment.
Is this needed? I thought the default runners come w/ rust...
There was a problem hiding this comment.
I think you need to install them manually
Comment on lines
+3
to
+4
| `export RUSTFLAGS='--cfg getrandom_backend="wasm_js'` | ||
| `wasm-pack build` |
There was a problem hiding this comment.
Suggested change
| `export RUSTFLAGS='--cfg getrandom_backend="wasm_js'` | |
| `wasm-pack build` | |
| ```shell | |
| scripts/buildwasm | |
| ``` |
kylebarron
reviewed
Feb 13, 2025
|
|
||
| set -e | ||
|
|
||
| wasm-pack build --no-typescript --target web --out-dir ../docs/pkg wasm |
There was a problem hiding this comment.
no typescript 🥲 (But actually not really important)
Comment on lines
+23
to
+24
| - name: Install Rust | ||
| uses: dtolnay/rust-toolchain@stable |
There was a problem hiding this comment.
I think you need to install them manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.