Skip to content

Commit

Permalink
Update release docs, and add missing ChangeLog entry
Browse files Browse the repository at this point in the history
  • Loading branch information
fendor committed Feb 27, 2024
1 parent dee1f50 commit b57c093
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 5 deletions.
1 change: 1 addition & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## 2.7.0.0

- Bindists for GHC 9.8.2
- Enable many more plugins, making GHC 9.8.2 fully supported
- Fix refactor code actions for vim
- Preserve HLint's diagnostic severity
- Many other bug fixes.
Expand Down
4 changes: 2 additions & 2 deletions RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@
- Afterwards, the artifacts are available at: `https://downloads.haskell.org/~hls/haskell-language-server-<version>/`
- Run `SIGNING_KEY=... ../../release/upload.sh purge_all` to remove CDN caches
- [ ] create PR to [ghcup-metadata](https://github.com/haskell/ghcup-metadata)
- [ ] update `ghcup-0.0.7.yaml` and `ghcup-vanilla-0.0.7.yaml`
- [ ] update `ghcup-vanilla-0.0.8.yaml` and `ghcup-vanilla-0.0.7.yaml`
- can use `sh scripts/release/create-yaml-snippet.sh <version>` to generate a snippet that can be manually inserted into the yaml files
- [ ] update `hls-metadata-0.0.1.json`
- ~~update `hls-metadata-0.0.1.json`~~ Currently unnecessary, GHCup builds its own HLS binaries and updates that file.
- utilize `cabal run ghcup-gen -- generate-hls-ghcs -f ghcup-0.0.7.yaml --format json --stdout` in the root of ghcup-metadata repository
- Be sure to mark the correct latest version and add the 'recommended' tag to the latest release.
- [ ] get sign-off on release
Expand Down
15 changes: 12 additions & 3 deletions scripts/release/download-gh-artifacts.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,21 @@ cd "gh-release-artifacts/haskell-language-server-${RELEASE}"
# github
gh release download "$RELEASE"

## We can't do cirrus releases any more, as we build HLS releases with ghcup vanilla binaries.
## Vanilla means "upstream", aka GHC HQ, and GHC HQ does not provide bindists for FreeBSD.
## Until we start using ghcup's mainstream distribution channel, we can't even begin to build
## binaries for FreeBSD. We keep this here for the next generation or when the situation changes.
##
## We don't use ghcup's mainstream distribution channel, as we only provide vanilla binaries
## as requested by the ghcup distribution channel team.
# cirrus
curl --fail -L -o "haskell-language-server-${RELEASE}-x86_64-freebsd.tar.xz" \
"https://api.cirrus-ci.com/v1/artifact/github/haskell/haskell-language-server/bindist/bindist/out/haskell-language-server-${RELEASE}-x86_64-freebsd.tar.xz?branch=${RELEASE}"
# curl --fail -L -o "haskell-language-server-${RELEASE}-x86_64-freebsd.tar.xz" \
# "https://api.cirrus-ci.com/v1/artifact/github/haskell/haskell-language-server/bindist/bindist/out/haskell-language-server-${RELEASE}-x86_64-freebsd.tar.xz?branch=${RELEASE}"


sha256sum haskell-language-server-* > SHA256SUMS
gpg --detach-sign -u "${SIGNER}" SHA256SUMS

gh release upload "$RELEASE" "haskell-language-server-${RELEASE}-x86_64-freebsd.tar.xz" SHA256SUMS SHA256SUMS.sig
## see comment above
# gh release upload "$RELEASE" "haskell-language-server-${RELEASE}-x86_64-freebsd.tar.xz" SHA256SUMS SHA256SUMS.sig
gh release upload "$RELEASE" SHA256SUMS SHA256SUMS.sig

0 comments on commit b57c093

Please sign in to comment.