Fix record layout (haskell#1851)

* Fix record layout * Don't change the record update rules Co-authored-by: Junyoung/Clare Jang <[email protected]> Co-authored-by: Potato Hatsue <[email protected]>
develop7 · May 21, 2021 · 37e0551 · 37e0551
1 parent a06b2e6
commit 37e0551
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 1 deletion.
diff --git a/ghcide/src/Development/IDE/GHC/ExactPrint.hs b/ghcide/src/Development/IDE/GHC/ExactPrint.hs
@@ -203,7 +203,7 @@ needsParensSpace HsMultiIf{}     = (All False, All False)
 needsParensSpace HsLet{}         = (All False, All True)
 needsParensSpace HsDo{}          = (All False, All False)
 needsParensSpace ExplicitList{}  = (All False, All False)
-needsParensSpace RecordCon{}     = (All False, All False)
+needsParensSpace RecordCon{}     = (All False, All True)
 needsParensSpace RecordUpd{}     = mempty
 needsParensSpace _               = mempty
 

diff --git a/plugins/hls-tactics-plugin/test/CodeAction/IntrosSpec.hs b/plugins/hls-tactics-plugin/test/CodeAction/IntrosSpec.hs
@@ -14,3 +14,6 @@ spec = do
   describe "golden" $ do
     introsTest 2 8 "GoldenIntros"
 
+  describe "layout" $ do
+    introsTest 4 24 "LayoutRec"
+
diff --git a/plugins/hls-tactics-plugin/test/golden/LayoutRec.expected.hs b/plugins/hls-tactics-plugin/test/golden/LayoutRec.expected.hs
@@ -0,0 +1,5 @@
+data Pair a b = Pair {pa :: a, pb :: b}
+
+p :: Pair (a -> a) (a -> b -> c -> b)
+p = Pair {pa = _, pb = \ a b c -> _}
+
diff --git a/plugins/hls-tactics-plugin/test/golden/LayoutRec.hs b/plugins/hls-tactics-plugin/test/golden/LayoutRec.hs
@@ -0,0 +1,5 @@
+data Pair a b = Pair {pa :: a, pb :: b}
+
+p :: Pair (a -> a) (a -> b -> c -> b)
+p = Pair {pa = _, pb = _}
+