Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

피드에서 추억 제거 #22

Merged
merged 3 commits into from
Dec 21, 2022
Merged

피드에서 추억 제거 #22

merged 3 commits into from
Dec 21, 2022

Conversation

hongbeomi
Copy link
Member

@hongbeomi hongbeomi commented Dec 19, 2022 •
edited
Loading

What?

  • 피드 화면에서 추억을 제거하는 기능 구현

Changes

  • DropDialog 구현
  • 추억 제거 API 구현 & 연결

Test Guide

  • 슈퍼 토큰 키 사용
  • 1탭 (피드 화면) 진입 -> 추억 옵션 메뉴에서 삭제 클릭 -> 다이얼로그에서 삭제 클릭 -> 삭제되고 refresh 되는 피드 확인

image

⚠️ Warning

@hongbeomi hongbeomi self-assigned this Dec 19, 2022
@hongbeomi hongbeomi mentioned this pull request Dec 19, 2022
Closed
3 tasks
junhyung0927
junhyung0927 reviewed Dec 20, 2022
View reviewed changes
Copy link
Collaborator

@junhyung0927 junhyung0927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

google-services.json 파일이 없다고 하네여
로컬, CI 모두 빌드가 안됩니다. 한 번 확인 부탁드려요!
나머지는 LGTM👏

@hongbeomi
Copy link
Member Author

@junhyung0927
.gitignore에 포함되어 발생하는 이슈로 확인 -> #24 로 추후 처리 요망. 그 전까진 firebase에서 파일 다운 받아 사용

@hongbeomi hongbeomi merged commit 1fce526 into main Dec 21, 2022
@hongbeomi hongbeomi deleted the feature/remove-feed-item branch December 21, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junhyung0927 junhyung0927 junhyung0927 left review comments

Assignees

@hongbeomi hongbeomi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hongbeomi @junhyung0927