Multi speaker support #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor Talk model to use ManyToMany fields for draft speakers and published speakers. Add data migration to migrate existing speaker data into the new structure. Adapt model, admin and form classes. Start fixing api_views, views and tests.
Alpine seem to have dropped openssl from its base image. This leads to runtime problems with the Psycopg2 PostgreSQL client library.
Implement code to remove unpublished talks of deleted speakers. Add tests for the signal handlers in talk.models.
jandd
requested review from
drombo,
jenslauterbach,
stefanbethke and
ronnyfriedland
jenslauterbach
approved these changes
Mar 12, 2020
|
Massive PR. Well done! Thank you. |
|
@jenslauterbach thanks for the review |
Pull Request Test Coverage Report for Build 660
💛 - Coveralls |
jandd
added a commit
to jandd/devday_website
that referenced
this pull request
Mar 12, 2020
The change in devdaydresden#255 introduced a regression on the speaker profile page (AttributeError in prefetch_related) that is fixed by this commit. A test to reproduce the error is included. addresses devdaydresden#251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented support for multiple speakers (addresses #251). The current implementation allows adding additional speakers in the admin interface. It does not implement user facing functionality to add additional speakers yet.
Addresses #237 for YouTube URLs for talk media.