Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[anaconda / miniconda] Update tests #842

Merged
merged 2 commits into from
Nov 8, 2023
Merged

[anaconda / miniconda] Update tests #842

merged 2 commits into from
Nov 8, 2023

Conversation

alexander-smolyakov
Copy link
Contributor

Devcontainer name:

  • anaconda
  • miniconda

Description:

We need to change the checkPythonPackageVersion function to make it work for all Python packages. In the previous implementation, the check relies on the __version__ attribute. Now function uses the importlib.metadata library to get the package version. This approach should work for all packages.

Changelog:

anaconda:

  • Reworked test for checking the tornado package version;
  • Reworked the checkPythonPackageVersion function to use the importlib.metadata library;

miniconda:

  • Reworked the checkPythonPackageVersion function to use the importlib.metadata library;

Checklist:

  • Checked that applied changes work as expected

- Rework test for checking the `tornado` package version;
- Rework `checkPythonPackageVersion` function to use `importlib.metadata` library;
- Rework `checkPythonPackageVersion` function to use `importlib.metadata` library;
@alexander-smolyakov alexander-smolyakov requested a review from a team as a code owner November 7, 2023 10:29
@samruddhikhandale samruddhikhandale merged commit b703500 into devcontainers:main Nov 8, 2023
4 checks passed
@alexander-smolyakov alexander-smolyakov deleted the anaconda-miniconda-update-tests branch November 8, 2023 06:12
@samruddhikhandale samruddhikhandale mentioned this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants