Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp] - buster - EOL #1127

Merged
merged 2 commits into from
Jul 16, 2024
Merged

[cpp] - buster - EOL #1127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fea177c
[cpp] - buster - EOL
gauravsaini04 Jul 12, 2024
593270d
more buster eol changes for cpp devcontainer
gauravsaini04 Jul 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/cpp/.devcontainer/base-scripts/install-vcpkg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,6 @@ USERNAME=${1:-"vscode"}

. /etc/os-release

# The buster pkg repo install cmake version < 3.15 which is required to run bootstrap-vcpkg.sh on ARM64
VCPKG_UNSUPPORTED_ARM64_VERSION_CODENAMES="buster"

if [ "$(dpkg --print-architecture)" = "arm64" ]; then
# Exit early if ARM64 OS does not have cmake version required to build Vcpkg
if [[ "${VCPKG_UNSUPPORTED_ARM64_VERSION_CODENAMES}" = *"${VERSION_CODENAME}"* ]]; then
echo "OS ${VERSION_CODENAME} ARM64 pkg repo installs cmake version < 3.15, which is required to build Vcpkg."
exit 0
fi
fi

# Add to bashrc/zshrc files for all users.
updaterc() {
echo "Updating /etc/bash.bashrc and /etc/zsh/zshrc..."
Expand Down
3 changes: 1 addition & 2 deletions src/cpp/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
| *Categories* | Core, Languages |
| *Image type* | Dockerfile |
| *Published images* | mcr.microsoft.com/devcontainers/cpp |
| *Available image variants* | debian-12, debian-11, debian-10, ubuntu-24.04, ubuntu-22.04, ubuntu-20.04 ([full list](https://mcr.microsoft.com/v2/devcontainers/cpp/tags/list)) |
| *Available image variants* | debian-12, debian-11, ubuntu-24.04, ubuntu-22.04, ubuntu-20.04 ([full list](https://mcr.microsoft.com/v2/devcontainers/cpp/tags/list)) |
| *Published image architecture(s)* | x86-64, aarch64/arm64 for `debian-12`, `debian-11`, `ubuntu-24.04` and `ubuntu-22.04` variants |
| *Container host OS support* | Linux, macOS, Windows |
| *Container OS* | Debian, Ubuntu |
Expand All @@ -25,7 +25,6 @@ You can directly reference pre-built versions of `Dockerfile` by using the `imag
- `mcr.microsoft.com/devcontainers/cpp:debian` (latest Debian GA)
- `mcr.microsoft.com/devcontainers/cpp:debian-12` (or `bookworm`)
- `mcr.microsoft.com/devcontainers/cpp:debian-11` (or `bullseye`)
- `mcr.microsoft.com/devcontainers/cpp:debian-10` (or `buster`)
- `mcr.microsoft.com/devcontainers/cpp:ubuntu` (latest Ubuntu LTS)
- `mcr.microsoft.com/devcontainers/cpp:ubuntu-24.04` (or `noble`)
- `mcr.microsoft.com/devcontainers/cpp:ubuntu-22.04` (or `jammy`)
Expand Down
9 changes: 0 additions & 9 deletions src/cpp/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"variants": [
"bookworm",
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved
"bullseye",
"buster",
"noble",
"jammy",
"focal"
Expand All @@ -13,7 +12,6 @@
"parent": {
"bookworm": "base-debian",
"bullseye": "base-debian",
"buster": "base-debian",
"noble": "base-ubuntu",
"jammy": "base-ubuntu",
"focal": "base-ubuntu"
Expand All @@ -28,9 +26,6 @@
"linux/amd64",
"linux/arm64"
],
"buster": [
"linux/amd64"
],
"noble": [
"linux/amd64",
"linux/arm64"
Expand Down Expand Up @@ -58,10 +53,6 @@
"cpp:${VERSION}-debian11",
"cpp:${VERSION}"
],
"buster": [
"cpp:${VERSION}-debian-10",
"cpp:${VERSION}-debian10"
],
"noble": [
"cpp:${VERSION}-ubuntu-24.04",
"cpp:${VERSION}-ubuntu24.04"
Expand Down
Loading