Skip to content

feat: add UV to python feature #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FabrizioCafolla
Copy link

@FabrizioCafolla FabrizioCafolla commented Apr 8, 2025

Hi, I opened a pull request for adding UV to Python feature

@FabrizioCafolla FabrizioCafolla requested a review from a team as a code owner April 8, 2025 15:52
@FabrizioCafolla
Copy link
Author

@microsoft-github-policy-service agree

@chrmarti
Copy link
Contributor

chrmarti commented Apr 9, 2025

Opened #1327 for the test failure which seems to be triggered by some update upstream.

@chrmarti chrmarti closed this Apr 17, 2025
@chrmarti chrmarti reopened this Apr 17, 2025
@chrmarti
Copy link
Contributor

Scenario tests are failing now:

2025-04-17T12:03:16.6787830Z [2025-04-17T12:03:16.678Z] #15 68.05 creating virtual environment...
2025-04-17T12:03:16.6788466Z #15 68.05 installing uv...
2025-04-17T12:03:16.6788912Z #15 68.05 Fatal error from pip prevented installation. Full pip output in file:
2025-04-17T12:03:16.6789475Z #15 68.05     /usr/local/py-utils/logs/cmd_2025-04-17_12.03.15_pip_errors.log
2025-04-17T12:03:16.6789802Z 
2025-04-17T12:03:16.8505320Z [2025-04-17T12:03:16.850Z] #15 68.06 
2025-04-17T12:03:16.8505951Z #15 68.06 Some possibly relevant errors from pip install:
2025-04-17T12:03:16.8506813Z #15 68.06     ERROR: Could not find a version that satisfies the requirement uv (from versions: none)
2025-04-17T12:03:16.8507565Z #15 68.06     ERROR: No matching distribution found for uv
2025-04-17T12:03:16.8508050Z #15 68.06 Error installing uv.
2025-04-17T12:03:16.8508406Z #15 68.06 
2025-04-17T12:03:16.8509521Z #15 68.07 ERROR: Feature "Python" (Unknown) failed to install! Look at the documentation at https://github.com/devcontainers/features/tree/main/src/python for help troubleshooting this error.
2025-04-17T12:03:16.8510610Z 
2025-04-17T12:03:16.8793658Z [2025-04-17T12:03:16.879Z] #15 ERROR: process "/bin/sh -c cp -ar /tmp/build-features-src/python_0 /tmp/dev-container-features  && chmod -R 0755 /tmp/dev-container-features/python_0  && cd /tmp/dev-container-features/python_0  && chmod +x ./devcontainer-features-install.sh  && ./devcontainer-features-install.sh  && rm -rf /tmp/dev-container-features/python_0" did not complete successfully: exit code: 1
2025-04-17T12:03:16.8794995Z 
2025-04-17T12:03:16.8853626Z [2025-04-17T12:03:16.885Z] ------
2025-04-17T12:03:16.8856084Z  > [dev_containers_target_stage 5/5] RUN --mount=type=bind,from=dev_containers_feature_content_source,source=python_0,target=/tmp/build-features-src/python_0     cp -ar /tmp/build-features-src/python_0 /tmp/dev-container-features  && chmod -R 0755 /tmp/dev-container-features/python_0  && cd /tmp/dev-container-features/python_0  && chmod +x ./devcontainer-features-install.sh  && ./devcontainer-features-install.sh  && rm -rf /tmp/dev-container-features/python_0:
2025-04-17T12:03:16.8857638Z 68.05 installing uv...
2025-04-17T12:03:16.8857955Z 68.05 Fatal error from pip prevented installation. Full pip output in file:
2025-04-17T12:03:16.8858383Z 68.05     /usr/local/py-utils/logs/cmd_2025-04-17_12.03.15_pip_errors.log
2025-04-17T12:03:16.8858692Z 68.06 
2025-04-17T12:03:16.8858904Z 68.06 Some possibly relevant errors from pip install:
2025-04-17T12:03:16.8859466Z 68.06     ERROR: Could not find a version that satisfies the requirement uv (from versions: none)
2025-04-17T12:03:16.8860488Z 68.06     ERROR: No matching distribution found for uv
2025-04-17T12:03:16.8860793Z 68.06 Error installing uv.
2025-04-17T12:03:16.8860993Z 68.06 
2025-04-17T12:03:16.8861650Z 68.07 ERROR: Feature "Python" (Unknown) failed to install! Look at the documentation at https://github.com/devcontainers/features/tree/main/src/python for help troubleshooting this error.
2025-04-17T12:03:16.8862337Z ------

@karthiknadig
Copy link

The test failure seems to be caused by attempting to install uv using python 3.6. python 3.6 is deprecated and should be updated for 3.9.

@FabrizioCafolla
Copy link
Author

FabrizioCafolla commented Apr 18, 2025

@karthiknadig Ok, how can we solve this? can't find the test where Python 3.6 is used

@karthiknadig
Copy link

@FabrizioCafolla i think all we need to do is only install it when version of Python is greater than 3.9.

@chrmarti can you provide any guidance for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants