Skip to content

Add custom instructions and bump versions #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2025
Merged

Conversation

bamurtaugh
Copy link
Member

Continuing from #1314

@bamurtaugh bamurtaugh requested a review from chrmarti April 4, 2025 00:13
@bamurtaugh bamurtaugh self-assigned this Apr 4, 2025
@bamurtaugh bamurtaugh requested a review from a team as a code owner April 4, 2025 00:13
@bamurtaugh
Copy link
Member Author

@chrmarti any input on why the Java tests are failing would be a great help too!

chrmarti
chrmarti previously approved these changes Apr 4, 2025
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@chrmarti
Copy link
Contributor

chrmarti commented Apr 4, 2025

I see #1316 will fix the Java feature.

@bamurtaugh
Copy link
Member Author

I see #1316 will fix the Java feature.

Ah thank you! Do you think we should wait to merge this one until that's merged?

eljog
eljog previously approved these changes Apr 6, 2025
@chrmarti
Copy link
Contributor

chrmarti commented Apr 7, 2025

@bamurtaugh Merged the other one. I'll leave resolving the conflict up to you, so my approval will still count afterwards. 😅

@bamurtaugh bamurtaugh dismissed stale reviews from eljog and chrmarti via c693710 April 7, 2025 18:45
@bamurtaugh
Copy link
Member Author

bamurtaugh commented Apr 7, 2025

Thanks @chrmarti! I just resolved the conflict (another bump in ruby feature version).

@bamurtaugh
Copy link
Member Author

bamurtaugh commented Apr 7, 2025

Since like @chrmarti mentioned, the previous approvals should still count:

image

But looks like GH wants another approving maintainer approval? 😄

@chrmarti
Copy link
Contributor

chrmarti commented Apr 7, 2025

We should be good with my approval now. I think GitHub wouldn't accept mine if I had done the merge.

@chrmarti
Copy link
Contributor

chrmarti commented Apr 7, 2025

Failing dotnet test is filed as dotnet/sdk#47865.

@bamurtaugh
Copy link
Member Author

Failing dotnet test is filed as dotnet/sdk#47865.

Thanks for linking! Should we merge anyways, considering this issue was already there?

@chrmarti
Copy link
Contributor

chrmarti commented Apr 7, 2025

I think so, the git test is hung, but I don't see that in the other recent PR. I will merge now.

@chrmarti chrmarti merged commit b89a41f into main Apr 7, 2025
169 of 170 checks passed
@chrmarti chrmarti deleted the bamurtaugh/instructions branch April 7, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants