Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debian failure to add ppas #508

Merged
merged 1 commit into from
Aug 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/neovim-apt-get/devcontainer-feature.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "neovim-apt-get",
"version": "1.0.17",
"version": "1.0.18",
"name": "Neovim (via apt-get)",
"documentationURL": "http://github.com/devcontainers-contrib/features/tree/main/src/neovim-apt-get",
"description": "Neovim is a fork of Vim focused on modern code and features, rather than running in legacy environments.",
Expand Down
7 changes: 4 additions & 3 deletions src/neovim-apt-get/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,15 @@ source ./library_scripts.sh
# `ensure_nanolayer` is a bash function that will find any existing nanolayer installations,
# and if missing - will download a temporary copy that automatically get deleted at the end
# of the script
ensure_nanolayer nanolayer_location "v0.4.29"
ensure_nanolayer nanolayer_location "v0.4.46"


$nanolayer_location \
install \
devcontainer-feature \
"ghcr.io/devcontainers-contrib/features/apt-get-packages:1.0.4" \
--option packages='neovim' --option ppas='ppa:neovim-ppa/stable' --option force_ppas_on_non_ubuntu='true'
"ghcr.io/devcontainers-contrib/features/apt-get-packages:1.0.6" \
--option packages='neovim' --option ppas='ppa:neovim-ppa/stable'



echo 'Done!'
Expand Down
8 changes: 7 additions & 1 deletion test/neovim-apt-get/scenarios.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
{
"test": {
"test_ubuntu": {
"image": "mcr.microsoft.com/devcontainers/base:ubuntu",
"features": {
"neovim-apt-get": {}
}
},
"test_debian": {
"image": "mcr.microsoft.com/devcontainers/base:debian",
"features": {
"neovim-apt-get": {}
}
}
}
File renamed without changes.
9 changes: 9 additions & 0 deletions test/neovim-apt-get/test_ubuntu.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#!/bin/bash -i

set -e

source dev-container-features-test-lib

check "nvim --version" nvim --version

reportResults