-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve kwargs #177
Closed
Closed
Preserve kwargs #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the circuit hierarchy.
…rks, but problems with bbox on rotated parts.
… with a node and 2) placement of nodes..
…counted for line thickness.
refactor: Rearranged some routines..
…played in the generated schematic.
…ata/schematics directory.
…same net would fail in routing.py. But now net variables can become invalid after generate_*() ops because of new merging.
…ic part placement to prevent non-terminating loop.
…sing parameters for each option.
… gen_schematic().
… windows get closed by pressing a key.
…n using pytest without being enabled under tox.
…cement. Does not work.
…ific keys, causing this to keyerror
…eration so empty footprint errors don't prevent the generation of a schematic.
…tic generation is done.
…ubstitute values in to preserve into netlist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#176
This PR simply stores duplicated keyword args into the
Part.fields
so that parts can pass duplicate kwargs to the netlist generators, ie "Datasheet" could exist in thePart.fields
andPart.Datasheet
when parts are passed these kwargs on creation.