Bug: Apple doesn't support passing both a currencyCode and numberStyle #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…encyCode supplied. This is needed since apple pukes if you pass both
mbaechtold
requested changes
Dec 16, 2016
.cache/v/cache/lastfailed
Outdated
| @@ -0,0 +1 @@ | |||
| {} | |||
There was a problem hiding this comment.
Could you please add a line to the .gitignore file, so this file does is added to the git repo:
# Unit test / coverage reports
.coverage
.tox
.cache # <--- Add this line.
There was a problem hiding this comment.
Thanks, but unfortunately I forgot to mention that you must delete this file too.
passbook/test/test_passbook.py
Outdated
| passfile.passInformation.headerFields.append(balance_field) | ||
| passfile.passInformation.addAuxiliaryField('aux1', 'VIP Store Card', 'Famous Inc.') | ||
| pass_json = passfile.json_dict() | ||
| print(pass_json) |
There was a problem hiding this comment.
I think this line should be removed?
mbaechtold
requested changes
May 5, 2017
.cache/v/cache/lastfailed
Outdated
| @@ -0,0 +1 @@ | |||
| {} | |||
There was a problem hiding this comment.
Thanks, but unfortunately I forgot to mention that you must delete this file too.
|
@johnksterling @mbaechtold Hi guys. Did something need to happen to merge this? I can see it didn't reach the master. Thanks! |
|
Would just changing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running into a problem where we set the currencyCode on the balance field of a pass, but never set the numberStyle - yet the passbook python library re-injects a default numberStyle. Apple, however, doesn't support having both a numberStyle and a currency field.
There are a few ways to resolve this, but I chose to just over-ride the json generation on CurrencyField to only strip numberStyle if currencyCode is present (which looks to be almost always, unless someone explicitly deletes one of them).
Note that the proposed solution will leave 'empty' the json as-is if one of them is an empty string. I am not sure if this is the desired behavior since we don't set either to empty string - bit it would be an easy change to check json_dictionary.get('currencyCode') and json_dictionary.get('currencyCode').strip() if that was preferred.
I have tested this with a couple of version of the ios and it seems to work well. Anyone else running into this and interested in fixing it?
Closes #38