Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MQTT entity names that start with device name #140

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

NewsGuyTor
Copy link

This should make it function better in Home Assistant

Copy link

@Capusjon Capusjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot to change the version on line 565.

static const String versionNum = "v7.1.5";

thats what I would suggest, it makes it so that we can see in the webinterface that the right version is uploaded.

@Capusjon
Copy link

Capusjon commented Dec 14, 2023

After implementing said changes almost all the warnings are gone. Only one that remains for me is:

2023-12-14 14:22:47.398 WARNING (MainThread) [homeassistant.components.sensor] Entity sensor.slaapkamergordijn_illuminance (<class 'homeassistant.components.mqtt.sensor.MqttSensor'>) is using native unit of measurement 'Level' which is not a valid unit for the device class ('illuminance') it is using; expected one of ['lx']; Please update your configuration if your entity is manually configured, otherwise create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+mqtt%22

changing line 3371 to

+ "\"unit_of_meas\": \"lx\", " +

should fix the warning, only issue I have with this fix is that the data produced by the Switchbot for Illuminance isn't in lux. So technically it's not the best solution, might need to use an other topic instead of illuminance. But for now this suits me and the warnings are gone.

@NewsGuyTor thanx for your part of the fix. If you could add in my previous comment that would be great, for this comment do with it what you want..

@NewsGuyTor
Copy link
Author

@Capusjon : Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants