Remove all global scopes instead of just trashed #34
+2
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the
loadRecord
only removes thetrashed
global scope when it is present.However, this causes a problem for other records with Global Scopes. It seems Nova itself will ignore these scopes when serving a detail page, so it means you can view records that then fail when you click on auditable log with the following error when the resource is not properly loaded.
As a side effect, the
withoutGlobalScopes
also removes the trashed scope, so you can remove the ternary.Let me know if you'd like me to take another approach, but I think this is fine with how Nova already works.