Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build(docker): changed Dockerfile to build from root requirements
This change moves the requirements build to use the requirements.txt
that uses setup.py (setuptools). This should bring the requirments a
developer might add to the repo closer to the deployment process
and reduce any impedance between how the app is deployed versus
how the app is developed.
Any decision to modify the
requirements.txt
inbuild/
is left toa different PR around the infrastructure / deployment process.
QA:
[-] execute a docker build, and confirm no errors
[-] execute
deploy.sh docker dev
and confirm no errors[-] visit site at http://localhost
[-] find a song and serenade yourself on how cool coding is
feature(setuptools): new requirements.txt
Added a new requirements.txt that points to setup.py for app setup.
This requirements.txt will install the requirements based on the apps
defined dependencies.
QA:
[-] install through new requirements.txt at root of project
[-] run the application
[-] were there no errors? Well aren't you a lucky tazmanian devil
build(setuptools): added a setup.py to the project
Added a
setup.py
for installation of the web portal through pythonsetuptools. This will prepare the app for build script.
Also created a symlink to the
build/requirements.txt
for now giventhat we want to tell requirements.txt to use the setup.py for the app.
QA:
[-] install the app locally and confirm no errors
[-] run the app
[-] comment on the nostalgia of the detroit black tech hero image