Fixing unique user name login bug.

dessalines · Jun 26, 2018 · a728a5f · a728a5f
1 parent 2e79cb5
commit a728a5f
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/service/src/main/java/com/simplevote/db/Actions.java b/service/src/main/java/com/simplevote/db/Actions.java
@@ -10,6 +10,8 @@
 import com.simplevote.types.User;
 
 import org.javalite.activejdbc.LazyList;
+import org.javalite.activejdbc.Model;
+
 import ch.qos.logback.classic.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -60,11 +62,21 @@ public static User signup(Long loggedInUserId, String userName, String password,
         }
 
         // Find the user, then create a login for them
+
+        LazyList<Tables.User> users;
+		if (email != null) {
+            users = Tables.User.find("name = ? or email = ?", userName, email);
+        } else {
+            users = Tables.User.find("name = ?", userName);
+        }
+
         Tables.User uv;
-        if (email != null) {
-            uv = Tables.User.findFirst("name = ? or email = ?", userName, email);
+        if (users.size() > 1) {
+            throw new NoSuchElementException("Username/email already exists");
+        } else if (users.size() == 1) {
+            uv = users.get(0);
         } else {
-            uv = Tables.User.findFirst("name = ?", userName);
+            uv = null;
         }
 
         if (uv == null) {