Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy to use Private Key terminology #120

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

triplegreenshell
Copy link

No description provided.

@triplegreenshell triplegreenshell requested a review from a team as a code owner February 19, 2022 04:44
@iPaulPro
Copy link
Contributor

Why would we call it a "key" when it is, in fact, a seed phrase?

@ItsAditya-xyz
Copy link

Let's NOT do this. Seed phrase is the apt wording here..

@tijno
Copy link
Contributor

tijno commented Feb 26, 2022

Unless work is being done to offer users a way to login with a "key" that is not a seed - then in no way should we confuse users!

a seed is a seed.

dont try and simplify this.

instead - lets find a better way of users loging in that does not require a seed!

@diamondhands0 diamondhands0 changed the title Update copy to use DeSo Key terminology Update copy to use Private Key terminology Feb 26, 2022
@diamondhands0
Copy link
Member

@iPaulPro @AdityaChaudhary0005 @tijno, wanted to thank you all for this input and provide some context on this change.

We've gotten a lot of feedback from the Crypto Twitter community that the use of the term "Seed Phrase" was causing people to enter their MetaMask seed phrase into the DeSo Identity portal.

This criticism was not only accurate, but it also caused people in the ETH ecosystem to think that DeSo Identity was somehow trying to co-opt peoples' MetaMask wallets. I know it's clear to you and me that this isn't the case, but unfortunately the ubiquitous use of the term "Seed Phrase" in the ETH ecosystem caused confusion among the ETH community.

But I also agree with you guys that we shouldn't compromise on accuracy for the sake of reducing confusion if we can help it. So I propose that we call it "Private Key." This is actually what the seed phrase represents, and it's arguably more accurate to call it this as far as I can tell, since ultimately it is their private key that controls their account.

It also feels like this will have the positive side-effect of increasing the level of security with which people store their seed phrase because they know that it is PRIVATE and that it acts as the KEY to their account. I also like that it squares with what I tell people in conversation, which is that their account on DeSo is controlled by their private key.

So I am an approve with this change.
image

@diamondhands0
Copy link
Member

@triplegreenshell would you kindly integrate this change from my branch into yours pior to squashing+merging?

https://github.com/deso-protocol/identity/commits/triplegreenshell/DESO-KEY-COPY-UPDATE

@ItsAditya-xyz
Copy link

ItsAditya-xyz commented Feb 27, 2022

To me, the term "DeSo seed" was much better than just "private key".
image
People were considering that it's asking for metamask seed phrase when the term was just "Seed"
Previous version of deso identity
I don't see a reason why someone will enter their metamask seed on deso identity which is asking for "DeSo seed"
Private key sounds more like a term which is used by devs who know cryptography and stuffs
Back to 10th jan, I had also given my feedback to change "Sign up with seed" to "Create deso wallet" this is when identity change it to "Sign up with DeSo Seed" (which imo solved the problem of misunderstanding deso seed with metamask seed)
image

just my few DeSoNanos on this topic

@tijno
Copy link
Contributor

tijno commented Feb 27, 2022

i really dont think this is any better and possibly more confusing.

a seed is not a private key

why not just add a note below:

your deso seed is different from other coins like ETH, BTC

or

dont use your metamask seed

@Bobnificent
Copy link

Not sure @diamondhands0 is aware that it was already changed to "sign up with DeSo Seed". Which makes it clear. If we turn it back to "Sign up with private key" It leads to a question... Which private key? Eth, BTC private key? I would suggest it stays "sign up with DeSo Seed" unless like @tijno says there is work being done to offer users a way to login with a "key" that is not a seed.

Screen Shot 2022-02-27 at 11 19 30

@darian-parrish
Copy link

darian-parrish commented Feb 28, 2022

@diamondhands0

I think a better consideration is just "login/signup with DeSo Identity" for the first frame. That sets the context as DeSo and will likely have the best longevity(also good branding everywhere).

Then on the next screen above the enter box(since the context is DeSo) can probably stick with Seed Phrase for now and maybe this becomes a derived key or something different in the future(but main CTA is "with DeSo Identity").

More context here: https://desocialworld.com/posts/ba13e79728fba3d815f64ea7164f46382ae80042c280c246886bee53830adc1d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants