refactor: redesign instagram api #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadamu
commented
Aug 10, 2023
Comment on lines
-26
to
-29
| user, err := suite.api.GetUser("leobragaz") | ||
| suite.Require().NoError(err) | ||
| suite.Require().NotEmpty(user.Username) | ||
| } |
There was a problem hiding this comment.
Remove the test since it requires accessToken right now, we should not post the token for security issue.
5 tasks
RiccardoM
approved these changes
Aug 14, 2023
RiccardoM
changed the title
RiccardoM
pushed a commit
that referenced
this pull request
Aug 14, 2023
…122) <!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> ## Description <!-- Small description --> This PR updates the Instagram data source to get media instead of biography. Depends-On: #117 ## Checklist - [ ] Targeted PR against correct branch. - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Wrote unit tests. - [ ] Updated the documentation. - [ ] Re-reviewed `Files changed` in the Github PR explorer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR redesign Instagram API to fit the official provided OAuth process:
https://developers.facebook.com/docs/instagram-api/reference/ig-user/
Update: 08:40:00, Aug 10, 2023 UTC:+0
Currently, it is impossible to get user biography by official API since it does not provide
biographyfield, see:https://developers.facebook.com/docs/marketing-api/reference/instagram-user/
In order to implement the application link process, we can only query the latest media posted by the given user, then store it into Themis cache for validating its proof later on.
Therefore, the whole process linking address to Instagram account would be like:
instagram_graph_user_profileandinstagram_graph_user_mediapermissionsChecklist
Files changedin the Github PR explorer.