Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for cosmos.gov.v1 messages #629

Merged
merged 29 commits into from
Jun 28, 2023
Merged

feat: add support for cosmos.gov.v1 messages #629

merged 29 commits into from
Jun 28, 2023

Conversation

manu0466
Copy link

@manu0466 manu0466 commented Jun 28, 2023 •
edited by RiccardoM
Loading

Description

This PR adds the support to the new x/gov messages

Closes: SDK-13
Closes: #625

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@manu0466
feat: generated x/gov v1 files
54ce648
@manu0466
feat: disabled rpc client generation
f39a1ae
@manu0466
feat: add amino types and converters
a7b4c9b
@manu0466
build: converted types generation function to ts
984725d
@manu0466
fix: re-added query generation
1f5f86a
@manu0466
fix: add support for gov v1 messages
db0f778
@manu0466
build: update file patching logic
743ea80
@manu0466
fix: amino serialization of MsgVote v1
5de73e4
@manu0466
test: update spawn chain script
8eb12d3
@manu0466
feat: add MsgVote integration tests
026596f
@manu0466
build: update get-proto script to download specific versions for cosm…
bcc9849 
…os and ibc
@manu0466
chore: update generated files
8b9e599
@manu0466
fix: generated files
41f26a9
@manu0466
chore: removed some death code
9791e09
@manu0466
refactor: moved test utility function from desmosclient.integration.s…
8cdc477 
…pec.ts
@manu0466
refactor: removed gov v1 related tests from desmosclient.integration.…
f6ef657 
…spec.ts
@manu0466
build: fix appendImport function
d3119fa
@manu0466
feat: add support to amino serialization/deserialization for types wi…
f8247f6 
…th a list of Any encoded messages
@manu0466
fix: from/to amino for MsgSubmitProposal
3deb001
@manu0466
chore: added missing amino type definitions in gov module
c1acd20
@manu0466
fix: MsgExecLegacyContent from/to amino
0a420fd
@manu0466
test: add some gov v1beta1 definitions for the tests
0df7cd2
@manu0466
test: update starting proposal id
05db30f
@manu0466
feat: add gov1 registers and amino converters
e0eb654
@manu0466
test: add gov v1 transaction broadcast integration tests
a6f9d9e
@manu0466
doc: added missing documentation
0d32f5f
@manu0466
deps: update yarn.lock
20dc512
@manu0466
build(deps): bump @cosmjs packages to 0.31.0
6b1887c
@github-actions github-actions bot added pkg/core Related to the core package pkg/types Related to the types package labels Jun 28, 2023
@github-actions github-actions bot added the pkg/walletconnect Related to the walletconnect package label Jun 28, 2023
@manu0466 manu0466 requested a review from RiccardoM June 28, 2023 16:23
@manu0466 manu0466 marked this pull request as ready for review June 28, 2023 16:23
RiccardoM
RiccardoM approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Jun 28, 2023
@mergify mergify bot merged commit a7af404 into main Jun 28, 2023
6 checks passed
@mergify mergify bot deleted the manuel/add-support-for-x-gov-v1 branch June 28, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiccardoM RiccardoM RiccardoM approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PR once all prerequisites pass pkg/core Related to the core package pkg/types Related to the types package pkg/walletconnect Related to the walletconnect package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manu0466 @RiccardoM