-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparation for PyPI and other fixes #212
Conversation
After some testing, I've modified the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Ben. I only reviewed names.py and the corresponding tests. The updates look great and bonus points for the clear comments explaining the various zero-pad choices. I'm happy with the changes and will approve that portion of the PR.
Thank you @akremin! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these updates. I put in one substantive comment about the dust ebv API change for consideration to postpone until we are making other non-backwards compatible changes for the 4.0 tag. I suggest that we not tackle the iers format change here beyond what you've already done with logging a warning; let's save that for a dedicated PR.
Either way, let's not merge this until Monday so that we aren't making a big update just before the weekend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick comment in case it's helpful: in FastSpecFit I fully deprecated the setup.cfg
file and ported the equivalent functionality to the pyproject.toml
file, as recommended by PEP 621 (see also pypa/setuptools#3683). That's obviously not necessary here but I did want to advertise the effort in case we decide to pursue this change for any of the other DESI packages.
Otherwise, the changes here all look excellent.
@moustakas, thank you, I should take a closer look at that. We might want to consider applying that to a (near) future desiutil 4.0. |
@sbailey, let's discuss some deployment considerations this afternoon before merging. |
The IERS table issue is moved to #214. |
This PR:
speclite
.bin/
are registered insetup.cfg
.pkg_resources
withimportlib.resources
.desiutil.setup.DesiTest
. That class was causing some serious problems with recent versions ofsetuptools
. Eventually we will want to remove other classes fromdesiutil.setup
, but removing just that one is good enough for now.However this PR is a WIP, since there are some open issues:
iers_frozen.ecsv
file with Astropy 7. However, we should also no longer need to use this file, since Astropy itself provides frozen versions. I think we still need to change the configuration to disable downloads, but I don't think we need to maintain a separate, frozen data file. This needs to be tested.doc/changes.rst
file.Finally, I have confirmed with a test version of the PyPI repository that desiutil can be successfully uploaded to PyPI.