Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style and API change in ebv() #213

Open
weaverba137 opened this issue Jan 13, 2025 · 1 comment
Open

Style and API change in ebv() #213

weaverba137 opened this issue Jan 13, 2025 · 1 comment
Assignees
Milestone

Comments

@weaverba137
Copy link
Member

The method desiutil.dust._Hemisphere.ebv(self, l, b, interpolate) triggers style warnings since l is considered a potentially ambiguous variable name. The suggested replacements are gal_l and gal_b, which are both more informative and unambiguous. However, since it is possible in principle that .ebv() is called with .ebv(l=..., b=..., ...), this is a potential API breaking change, so this should be applied to a future desiutil 4.0.

@weaverba137 weaverba137 self-assigned this Jan 13, 2025
@weaverba137 weaverba137 added this to the desiutil 4.0 milestone Jan 13, 2025
@weaverba137
Copy link
Member Author

I did a search for calls of .ebv(). I found no instances where .ebv() is called with l and b set as keywords. Furthermore, the .ebv() method that is proposed to be changed is actually wrapped by other .ebv() methods and/or the desiutil.dust.ebv() function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant