fix fibermap dtype for astropy 1.3 #380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works around a change in behavior from astropy 1.2 to 1.3, likely related to the units issue we had to work around desihub/specsim#62:
Under astropy 1.2, assigning a value to a table column would retain the original dtype of that column. Under astropy 1.3, the column gets the new dtype of the right-hand-side value. This breaks some consistency checks for fibermap columns though I don't think it broke any actual functionality (for desispec).
This PR also fixes two smaller issues that I found while debugging this:
desispec.io.Brick
couldn't be created with a filename that didn't include a path (it would parse the path as '' and then try to create '' and complain)LAMBDAREF
andLAMBDA_REF
I have tested with astropy 1.3 on edison and astropy 1.2 on my laptop. I'm Leaving
.travis.yml
at astropy 1.2.1 for now; the nightly cronjob unit tests on edison test master with astropy 1.3.