Fluxcalib variance fix #2422
Merged
Fluxcalib variance fix #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienguy
approved these changes
Dec 3, 2024
|
I checked the code is running and results is smaller inverse variance for bright objects. |
|
thank you for merging quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix to #2420
I've added an extra test is for test_fluxcalibration which tests a case of infinite S/N spectra, but finite S/N for calibration vector. In that case the correct S/N of the flux-calibrated spectrum should be the same as of the calibration vector
Previously the tests only considered the case of infinite S/N fluxcalib vector.