Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the etc for the backup program #14

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix the etc for the backup program #14

merged 1 commit into from
Oct 16, 2024

Conversation

segasai
Copy link
Contributor

@segasai segasai commented Oct 2, 2024

Thanks to @dkirkby @schlafly (in desihub/desispec#2370 ) I was able to run ETC on an exposure, and
looking at the json allowed to me figure out why the backup program switch doesn't trigger.
The check was written as

if self.fassign_data['FAPRGRM'] != 'BACKUP':

FAPRGRM !='BACKUP' while it's actually is 'backup' :)

This patch fixes that.

I checked that for the exposure 252068 before the etc was returning :
"MW_transp": 0.613693618072619
while with the patch it does
"MW_transp": 1

@schlafly
Copy link

Beautiful, this looks good to me! So when we merge & install this at KP we should also merge the corresponding update on desispec, and then these tiles start working right. Thank you!

@dkirkby dkirkby merged commit 6e44305 into main Oct 16, 2024
@dkirkby dkirkby deleted the backup_etc_fix branch October 16, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants