Add IAM Bindings and Update Documentation #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
In this update, I added the IAM bindings and supporting variables in order to assign
roles/pubsub.publisher
androles/pubsub.publisher
to the subscription. This should resolve a warning after creation in the console that the subscription does not have the correct permissions to use the dead letter topic/subscription.I also:
terraform-docs
output into it's own.md
file to make the view on the registry more usable.labels
variable so it is no longer required. We use it, but that doesn't mean it is required should someone else stumble across it.