feature create terraform module for pub sub topics sc 308777 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nathanknowles
commented
Nov 20, 2024
nathanknowles
commented
- chore: add terraform-docs config
- feat(terraform): update IAM policy resources for Pub/Sub
- Switched from `google_pubsub_topic_iam_binding` to `google_pubsub_topic_iam_member` and `google_pubsub_subscription_iam_member` to avoid destructive updates to IAM policies. Using `iam_binding` was removing all existing members from the policy when applying a single-member array, as confirmed during testing, despite unclear documentation. - Updated the "Subscriber" policy to apply to the subscription instead of the dead letter topic. This ensures the subscription can read messages and forward them to the dead letter topic, resolving the incorrect resource target issue.
IanKnighton
approved these changes
Nov 20, 2024
nathanknowles
deleted the
feature-create-terraform-module-for-pub-sub-topics-sc-308777
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.