Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Commit

Permalink
alsdkfjqowr
Browse files Browse the repository at this point in the history
  • Loading branch information
H Hatfield committed Apr 7, 2015
1 parent d6d511e commit 61caed2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Gelf/Transport/AbstractTransport.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public function getMessageEncoder()
*
* @return int the number of bytes sent
*/
abstract public function send(MessageInterface $message);

This comment has been minimized.

Sign in to view

Copy link
@bzikarsky

bzikarsky Apr 8, 2015

How does PHP5.3.3 behave, when you completely remove the abstract function definition, instead of defining it with an empty body?

This comment has been minimized.

Sign in to view

Copy link
@hhatfield

hhatfield via email Apr 8, 2015

This comment has been minimized.

Sign in to view

Copy link
@bzikarsky

bzikarsky Apr 8, 2015

I'd be willing to integrate this upstream, if there is either an empty implementation throwing a LogicException ("no implemented") with a comment explaining why there is no correct abstract method or PHP5.3.0-PHP7 work correctly with the method being omitted completely.

This comment has been minimized.

Sign in to view

Copy link
@hhatfield

hhatfield Apr 8, 2015

I just tested it in our stage environment running PHP5.3.3 and removing the function definition works fine.

This comment has been minimized.

Sign in to view

Copy link
@bzikarsky

bzikarsky Apr 8, 2015

Can you open a PR (including the composer-dependency change to php: ~5.3 and an updated composer.lock) and confirm that phpunit is "green" on PHP5.3.3 in the descrption? That would be awesome!
public function send(MessageInterface $message){}

/**
* Alias to send() without return value
Expand Down

0 comments on commit 61caed2

Please sign in to comment.